Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirection push fix #4286

Merged
merged 5 commits into from
Dec 4, 2024
Merged

Redirection push fix #4286

merged 5 commits into from
Dec 4, 2024

Conversation

gilzow
Copy link
Collaborator

@gilzow gilzow commented Dec 3, 2024

Why

Closes #4282

What's changed

redirection-verification action:

  • Adds a retry input on the action for the number of times will check the target url for a proper response. default is 100 retries with a 1 second delay between checks
  • Adds a check to the target URL (PR UR) to make sure it is up and responding (200 response) before we begin testing contracted redirections.

Where are changes

@gilzow gilzow self-assigned this Dec 3, 2024
@chadwcarlson chadwcarlson merged commit 7078b88 into main Dec 4, 2024
16 checks passed
@chadwcarlson chadwcarlson deleted the redirection-push-fix branch December 4, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chadwcarlson chadwcarlson chadwcarlson approved these changes

Assignees

@gilzow gilzow

Labels
markdown/prose
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add a delay to the contracted link checks
3 participants
@gilzow @chadwcarlson @platformsh-devrel